Skip to content

MINOR: change the field header name in ConsumerPerformance #20615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

MINOR: change the field header name in ConsumerPerformance #20615

wants to merge 1 commit into from

Conversation

DL1231
Copy link
Contributor

@DL1231 DL1231 commented Sep 30, 2025

@github-actions github-actions bot added triage PRs from the community tools small Small PRs labels Sep 30, 2025
chia7712
chia7712 approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the triage PRs from the community label Oct 1, 2025
AndrewJSchofield
AndrewJSchofield reviewed Oct 1, 2025
View reviewed changes
Copy link
Member

@AndrewJSchofield AndrewJSchofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I'm afraid that I don't quite see the point in this change. I think it makes it more confusing.

@chia7712
Copy link
Member

chia7712 commented Oct 4, 2025

I'm afraid that I don't quite see the point in this change. I think it makes it more confusing.

My point is the way joinTimeMsInSingleRound and joinTimeMs are updated does not match the description for rebalance.time.ms. Perhaps a more fitting name would be empty.assignment.time.ms. Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewJSchofield AndrewJSchofield AndrewJSchofield left review comments

@chia7712 chia7712 chia7712 approved these changes

Assignees
No one assigned
Labels
ci-approved small Small PRs tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DL1231 @chia7712 @AndrewJSchofield