KAFKA-19720: Regex subscription should be empty for classic members joining mixed group #20626
+76
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic protocol member
github-actions
bot
added
triage
There was a problem hiding this comment.
Thanks for fixing the bug!
Do we need to add a call to maybeUpdateRegularExpressions in classicGroupJoinToConsumerGroup? hasMemberSubscriptionChanged only checks the literal topic names in the subscription.
maybeUpdateRegularExpressions will also emit a tombstone for the resolved regex.
I think we should also test that the assignor is triggered if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't recompute the assignment on consumer -> classic member replacement when the consumer member had a regex subscription and the classic member does not.
This PR sets regex subscription to empty during the replacement.