MINOR: Add plugin.path config non-empty check in connect-plugin-path.sh #20638
+81
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1a2st
reviewed
Oct 5, 2025
| } | ||
| String pluginPath = properties.getProperty(WorkerConfig.PLUGIN_PATH_CONFIG); | ||
| if (pluginPath != null) { | ||
| validatePluginPath(pluginPath, WorkerConfig.PLUGIN_PATH_CONFIG); |
There was a problem hiding this comment.
I think we should throw a ConfigException when validating WorkerConfig.PLUGIN_PATH_CONFIG at this stage. This would preserve the same behavior as when WorkerConfig.PLUGIN_PATH_CONFIG is set to an empty value in the config.
| "" | ||
| ); | ||
| assertNotEquals(0, res.returnCode); | ||
| assertTrue("'--plugin-path' must not be empty.\n".equals(res.err)); |
There was a problem hiding this comment.
Please use assertEquals to validate the error message.
| "location-a,,location-b" | ||
| ); | ||
| assertNotEquals(0, res.returnCode); | ||
| assertTrue("'--plugin-path' values must not be empty.\n".equals(res.err)); |
| configPath.toString() | ||
| ); | ||
| assertNotEquals(0, res.returnCode); | ||
| assertTrue("'plugin.path' must not be empty.\n".equals(res.err)); |
| configPath.toString() | ||
| ); | ||
| assertNotEquals(0, res.returnCode); | ||
| assertTrue("'plugin.path' values must not be empty.\n".equals(res.err)); |
|
Thanks @m1a2st review, I have made the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAFKA-19112 defines the
plugin.pathconfig as non-empty. This PR add validation forplugin.pathrelated config in theconnect-plugin-path.shtool to satisfy the same non-empty semantics, addressing the issue mentioned here.