Skip to content

KAFKA-19831: Improved error handling in DefaultStateUpdater. (#20767) #20958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 4.1
Choose a base branch
from
+376 −42
Open

KAFKA-19831: Improved error handling in DefaultStateUpdater. (#20767) #20958

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55bae7e
KAFKA-19831: Improved error handling in DefaultStateUpdater. (#20767)
Nikita-Shupletsov Nov 21, 2025
fe30914
Added an additional wait for rebalance as it's taking longer.
Nikita-Shupletsov Nov 24, 2025
db9d577
Fixed formatting.
Nikita-Shupletsov Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...rc/test/java/org/apache/kafka/streams/integration/StateUpdaterFailureIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import org.apache.kafka.clients.consumer.ConsumerConfig;
import org.apache.kafka.common.serialization.Serdes;
import org.apache.kafka.common.utils.LogContext;
import org.apache.kafka.common.utils.MockTime;
import org.apache.kafka.streams.KafkaStreams;
import org.apache.kafka.streams.StreamsConfig;
Expand All @@ -42,6 +43,7 @@
import java.time.Duration;
import java.util.Properties;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;

import static org.apache.kafka.streams.utils.TestUtils.safeUniqueTestName;
Expand Down Expand Up @@ -146,6 +148,8 @@ public void flush() {

streams.removeStreamThread();

TestUtils.waitForCondition(() -> streams.state() == KafkaStreams.State.REBALANCING, TimeUnit.MINUTES.toMillis(2), "Streams never reached REBALANCING state");
Copy link
Member

@mjsax mjsax Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this only for 4.1 branch?

Copy link
Contributor Author

@Nikita-Shupletsov Nikita-Shupletsov Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason in 4.1 branch rebalancing kicks in only after ~1 minute after the thread is removed. it didn't happen in trunk


// Before shutting down, we want the tasks to be reassigned
TestUtils.waitForCondition(() -> numberOfStoreInits.get() == 9, "Streams never reinitialized the store enough times");

Expand Down
Loading