MINOR: Skip testDsaKeyPair when DSA algorithm is not supported #20967
+37
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jian <[email protected]>
github-actions
bot
added
triage
Signed-off-by: Jian <[email protected]>
Signed-off-by: Jian <[email protected]>
Contributor
gaurav-narula
left a comment
gaurav-narula
left a comment
There was a problem hiding this comment.
Thanks for the change!
I'm wondering how we deduced from the logs that the test fails due to DSA not being supported by the JVM and not test flakyness. The stacktrace you shared indicates the test fails because the channel's not ready but I don't see anything pointing that it's not ready because this algorithm isn't supported
Contributor
Author
|
@gaurav-narula Yes, you’re right. My bad for forgetting to add the background info in the PR description—I’ve already corrected it. |
Member
@gaurav-narula nice question. Please check the following log. |
chia7712
reviewed
Nov 24, 2025
| // Common patterns: TLS_DHE_DSS_*, TLS_DH_DSS_*, SSL_DHE_DSS_*, SSL_DH_DSS_* | ||
| return Arrays.stream(cipherSuites) | ||
| .anyMatch(suite -> suite.contains("_DSS_")); | ||
| } catch (Exception e) { |
Member
There was a problem hiding this comment.
not sure why we get this branch? SSLContext.getInstance gets error if tlsv1.2 is not supported?
Contributor
Author
There was a problem hiding this comment.
@chia7712 yes. I change the 1.2 to 1.8 and take a snapshot for it:
Member
There was a problem hiding this comment.
understand, it will certainly be an issue if tlsv1.2 is dropped. I'm confident Apache Kafka' lifespan will exceed that necessity
Member
|
the patch pass on my local. I'd like to merge it if the comment gets resolved. |
chia7712
approved these changes
Nov 25, 2025
chia7712
pushed a commit
to chia7712/kafka
that referenced
this pull request
Nov 25, 2025
…e#20967) Background: apache#20961 (comment) ``` Gradle Test Run :clients:test > Gradle Test Executor 7 > SslTransportLayerTest > testDsaKeyPair(Args) > "testDsaKeyPair(Args).args=tlsProtocol=TLSv1.2, useInlinePem=true" FAILED org.opentest4j.AssertionFailedError: Channel 0 was not ready after 30 seconds ==> expected: <true> but was: <false> at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) at app//org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63) at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36) at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214) at app//org.apache.kafka.common.network.NetworkTestUtils.waitForChannelReady(NetworkTestUtils.java:107) at app//org.apache.kafka.common.network.NetworkTestUtils.checkClientConnection(NetworkTestUtils.java:70) at app//org.apache.kafka.common.network.SslTransportLayerTest.verifySslConfigs(SslTransportLayerTest.java:1326) at app//org.apache.kafka.common.network.SslTransportLayerTest.testDsaKeyPair(SslTransportLayerTest.java:483) ``` Reviewers: Gaurav Narula <[email protected]>, Chia-Ping Tsai <[email protected]>
chia7712
pushed a commit
that referenced
this pull request
Nov 25, 2025
Background: #20961 (comment) ``` Gradle Test Run :clients:test > Gradle Test Executor 7 > SslTransportLayerTest > testDsaKeyPair(Args) > "testDsaKeyPair(Args).args=tlsProtocol=TLSv1.2, useInlinePem=true" FAILED org.opentest4j.AssertionFailedError: Channel 0 was not ready after 30 seconds ==> expected: <true> but was: <false> at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) at app//org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63) at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36) at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214) at app//org.apache.kafka.common.network.NetworkTestUtils.waitForChannelReady(NetworkTestUtils.java:107) at app//org.apache.kafka.common.network.NetworkTestUtils.checkClientConnection(NetworkTestUtils.java:70) at app//org.apache.kafka.common.network.SslTransportLayerTest.verifySslConfigs(SslTransportLayerTest.java:1326) at app//org.apache.kafka.common.network.SslTransportLayerTest.testDsaKeyPair(SslTransportLayerTest.java:483) ``` Reviewers: Gaurav Narula <[email protected]>, Chia-Ping Tsai <[email protected]>
chia7712
pushed a commit
that referenced
this pull request
Nov 25, 2025
Background: #20961 (comment) ``` Gradle Test Run :clients:test > Gradle Test Executor 7 > SslTransportLayerTest > testDsaKeyPair(Args) > "testDsaKeyPair(Args).args=tlsProtocol=TLSv1.2, useInlinePem=true" FAILED org.opentest4j.AssertionFailedError: Channel 0 was not ready after 30 seconds ==> expected: <true> but was: <false> at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) at app//org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63) at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36) at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214) at app//org.apache.kafka.common.network.NetworkTestUtils.waitForChannelReady(NetworkTestUtils.java:107) at app//org.apache.kafka.common.network.NetworkTestUtils.checkClientConnection(NetworkTestUtils.java:70) at app//org.apache.kafka.common.network.SslTransportLayerTest.verifySslConfigs(SslTransportLayerTest.java:1326) at app//org.apache.kafka.common.network.SslTransportLayerTest.testDsaKeyPair(SslTransportLayerTest.java:483) ``` Reviewers: Gaurav Narula <[email protected]>, Chia-Ping Tsai <[email protected]>
Member
|
trunk:cdc4019 @clolov I cherry-picked this to 4.2 branch because it was obstructing us from testing in env lacking DSA support |
Member
|
@jiafu1115 could you please open a patch for 3.9 branch? the cherry-pick is failed |
chia7712
pushed a commit
that referenced
this pull request
Nov 25, 2025
Create this PR to merge to 3.9 with #20967 due to the cherry pick fail #20967 (comment) Fix: ``` javax.net.ssl|ERROR|E1|echoserver|2025-11-24 14:34:37.602 CST|TransportContext.java:375|Fatal (HANDSHAKE_FAILURE): no cipher suites in common ( "throwable" : { javax.net.ssl.SSLHandshakeException: (handshake_failure) no cipher suites in common at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:130) at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:117) at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:370) at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:326) at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:317) at java.base/sun.security.ssl.ServerHello$T12ServerHelloProducer.chooseCipherSuite(ServerHello.java:459) at java.base/sun.security.ssl.ServerHello$T12ServerHelloProducer.produce(ServerHello.java:285) at java.base/sun.security.ssl.SSLHandshake.produce(SSLHandshake.java:437) at java.base/sun.security.ssl.ClientHello$T12ClientHelloConsumer.consume(ClientHello.java:1110) at java.base/sun.security.ssl.ClientHello$ClientHelloConsumer.onClientHello(ClientHello.java:843) at java.base/sun.security.ssl.ClientHello$ClientHelloConsumer.consume(ClientHello.java:798) at java.base/sun.security.ssl.SSLHandshake.consume(SSLHandshake.java:393) at java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:477) at java.base/sun.security.ssl.SSLEngineImpl$DelegatedTask$DelegatedAction.run(SSLEngineImpl.java:1273) at java.base/sun.security.ssl.SSLEngineImpl$DelegatedTask$DelegatedAction.run(SSLEngineImpl.java:1260) at java.base/java.security.AccessController.doPrivileged(AccessController.java:714) at java.base/sun.security.ssl.SSLEngineImpl$DelegatedTask.run(SSLEngineImpl.java:1205) at org.apache.kafka.common.network.SslTransportLayer.runDelegatedTasks(SslTransportLayer.java:444) at org.apache.kafka.common.network.SslTransportLayer.handshakeUnwrap(SslTransportLayer.java:533) at org.apache.kafka.common.network.SslTransportLayer.doHandshake(SslTransportLayer.java:382) at org.apache.kafka.common.network.SslTransportLayer.handshake(SslTransportLayer.java:302) at org.apache.kafka.common.network.KafkaChannel.prepare(KafkaChannel.java:178) at org.apache.kafka.common.network.Selector.pollSelectionKeys(Selector.java:548) at org.apache.kafka.common.network.Selector.poll(Selector.java:486) at org.apache.kafka.common.network.NioEchoServer.run(NioEchoServer.java:221)} ``` Reviewers: PoAn Yang <[email protected]>, Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
#20961 (comment)
Reviewers: Gaurav Narula [email protected], Chia-Ping Tsai
[email protected]