-
Notifications
You must be signed in to change notification settings - Fork 14.9k
KAFKA-20026: Reduce the list metadata calls to RLMM during segment cleanup #21213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95a8ab0 to
6ddd6b7
Compare
6ddd6b7 to
b9e6545
Compare
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
Contributor
Author
showuon
reviewed
Jan 6, 2026
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java
Show resolved
Hide resolved
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerTest.java
Outdated
Show resolved
Hide resolved
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerTest.java
Outdated
Show resolved
Hide resolved
0b6a339 to
8ca1488
Compare
showuon
approved these changes
Jan 6, 2026
Member
showuon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
storage
Pull requests that target the storage module
tiered-storage
Related to the Tiered Storage feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remote-log segments for a partition including the stale segments.
listRemoteLogSegments(tpId) and listRemoteLogSegments(tpId, epoch) will
match as the deletion proceeds, then the subsequent calls to
buildRetentionSizeDatashould not validate / invoke thelistRemoteLogSegments(tpId, epoch) again.
calls to RLMM and saves CPU resources.
Note that COPY_SEGMENT_STARTED state is excluded from the
remoteLogSizeInBytesmetric calculation as it pollutes the metricduring the upload retries.
Reviewers: Luke Chen showuon@gmail.com