Skip to content

Conversation

@jack2012aa
Copy link
Contributor

@jack2012aa jack2012aa commented Dec 28, 2025

Description

As discussed in the
comment,
some tests in BaseProducerSendTest didn't use consumer at all.

Since the testInfo parameter is required by QuorumTestHarness, this PR
lets those tests pass
getTestGroupProtocolParametersConsumerGroupProtocolOnly as parameter
instead of parameters all.

# Conflicts:
#	core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala
@github-actions github-actions bot added triage PRs from the community core Kafka Broker tests Test fixes (including flaky tests) small Small PRs labels Dec 28, 2025
@jack2012aa jack2012aa marked this pull request as ready for review December 28, 2025 06:03
@chia7712 chia7712 changed the title Minor: Simplify Tests Independent from Consumer in BaseProducerSendTest MINOR: Simplify Tests Independent from Consumer in BaseProducerSendTest Dec 28, 2025
@chia7712
Copy link
Member

chia7712 commented Jan 4, 2026

testSendOffset, testSendCompressedMessageWithCreateTime, testSendNonCompressedMessageWithCreateTime, and testSendBeforeAndAfterPartitionExpansion don't need the consumer, right?

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@jack2012aa
Copy link
Contributor Author

testSendOffset, testSendCompressedMessageWithCreateTime, testSendNonCompressedMessageWithCreateTime, and testSendBeforeAndAfterPartitionExpansion don't need the consumer, right?

@chia7712 Thanks for the review!
True. I also found out that most tests in PlaintextProducerSendTest don't need the consumer. Should I simplify those tests together with the four tests that you mentioned?

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved core Kafka Broker needs-attention small Small PRs tests Test fixes (including flaky tests) triage PRs from the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants