-
Notifications
You must be signed in to change notification settings - Fork 14.9k
MINOR: Simplify Tests Independent from Consumer in BaseProducerSendTest #21215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
MINOR: Simplify Tests Independent from Consumer in BaseProducerSendTest #21215
Conversation
# Conflicts: # core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala
|
|
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
@chia7712 Thanks for the review! |
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
Description
As discussed in the
comment,
some tests in
BaseProducerSendTestdidn't use consumer at all.Since the testInfo parameter is required by
QuorumTestHarness, this PRlets those tests pass
getTestGroupProtocolParametersConsumerGroupProtocolOnlyas parameterinstead of parameters all.