-
Notifications
You must be signed in to change notification settings - Fork 14.9k
KAFKA-20027: Fix the broken quick start link #21243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
m1a2st
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@m1a2st Good idea, done:) |
docs/getting-started/quickstart.md
Outdated
| In this quickstart we'll see how to run Kafka Connect with simple connectors that import data from a file to a Kafka topic and export data from a Kafka topic to a file. | ||
|
|
||
| First, make sure to add `connect-file-4.3.0.jar` to the `plugin.path` property in the Connect worker's configuration. For the purpose of this quickstart we'll use a relative path and consider the connectors' package as an uber jar, which works when the quickstart commands are run from the installation directory. However, it's worth noting that for production deployments using absolute paths is always preferable. See [plugin.path](/documentation/#connectconfigs_plugin.path) for a detailed description of how to set this config. | ||
| First, make sure to add `connect-file-4.3.0.jar` to the `plugin.path` property in the Connect worker's configuration. For the purpose of this quickstart we'll use a relative path and consider the connectors' package as an uber jar, which works when the quickstart commands are run from the installation directory. However, it's worth noting that for production deployments using absolute paths is always preferable. See [plugin.path](/configuration/kafka-connect-configs/#connectconfigs_plugin.path) for a detailed description of how to set this config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this fix correct? It does not seem to point to an existing file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, the original URL was missing the version prefix. It looks like using a relative path is the best approach, and it should be working now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears the correct link is ../configuration/kafka-connect-configs/#connectconfigs_plugin.path, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment. The link ../configuration/kafka-connect-configs/#connectconfigs_plugin.path leads to a 404 error.

However, ../../configuration/kafka-connect-configs/#connectconfigs_plugin.path works in my environment. I am not sure if this difference is due to my specific testing method or environment setup.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on the website, and it seems that ../../configuration/kafka-connect-configs/#connectconfigs_plugin.path redirects to the correct section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake, the current version is actually correct
This PR fix the broken `quickstart` link on the connector page. <img width="1094" height="604" alt="image" src="https://github.com/user-attachments/assets/d9a160b4-de09-422b-bd5a-c3bca6e73cac" /> Reviewers: Ken Huang <[email protected]>, Chia-Ping Tsai <[email protected]>
This PR fix the broken `quickstart` link on the connector page. <img width="1094" height="604" alt="image" src="https://github.com/user-attachments/assets/d9a160b4-de09-422b-bd5a-c3bca6e73cac" /> Reviewers: Ken Huang <[email protected]>, Chia-Ping Tsai <[email protected]>
This PR fix the broken `quickstart` link on the connector page. <img width="1094" height="604" alt="image" src="https://github.com/user-attachments/assets/d9a160b4-de09-422b-bd5a-c3bca6e73cac" /> Reviewers: Ken Huang <[email protected]>, Chia-Ping Tsai <[email protected]>
This PR fix the broken `quickstart` link on the connector page. <img width="1094" height="604" alt="image" src="https://github.com/user-attachments/assets/d9a160b4-de09-422b-bd5a-c3bca6e73cac" /> Reviewers: Ken Huang <[email protected]>, Chia-Ping Tsai <[email protected]>
This PR fix the broken `quickstart` link on the connector page. <img width="1094" height="604" alt="image" src="https://github.com/user-attachments/assets/d9a160b4-de09-422b-bd5a-c3bca6e73cac" /> Reviewers: Ken Huang <[email protected]>, Chia-Ping Tsai <[email protected]>

This PR fix the broken
quickstartlink on the connector page.Reviewers: Ken Huang [email protected], Chia-Ping Tsai
[email protected]