KNOX-3263: Setting JVM's default truststore password as a System property when creating CM service discovery ApiClient, if needed#1159
Merged
smolnar82 merged 1 commit intoapache:masterfrom Feb 26, 2026
Conversation
smolnar82
assigned
moresandeep,
hanicz and
pzampino and unassigned
moresandeep,
hanicz and
pzampino
Test Results7 tests 7 ✅ 1s ⏱️ Results for commit 830fc51. ♻️ This comment has been updated with latest results. |
…erty when creating CM service discovery ApiClient, if needed
hanicz
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3263 - Setting
javax.net.ssl.trustStorePasswordconditionally when creating CM's ApiClientWhat changes were proposed in this pull request?
DiscoveryApiClient creation is extracted to a factory class, where the
javax.net.ssl.trustStorePasswordSystem property is set if thecm.discovery.trustStorePasswordgateway-level alias is provided just before we initiate that class.How was this patch tested?
Manually tested in a FIPS-enabled cluster with/without configuring the
cm.discovery.trustStorePasswordgateway-level alias. Without that, I experineced the original issue: the default trustore couldnt be loaded and CM service discovery failed.With the alias in place, issuer were gone, Knox could discover the configured cluster and could connect to it every minute using the
PollingConfigurationAnalyzerchecking for changes.Integration Tests
N/A
UI changes
N/A