Skip to content

KNOX-3097 Add more redirect.whitelist Test Cases for KNOXSSO #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmccay merged 4 commits into from
Feb 18, 2025
Merged

KNOX-3097 Add more redirect.whitelist Test Cases for KNOXSSO #991

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1b5ef8
KNOX-3096 - Remote Auth Provider initial commit
lmccay Feb 17, 2025
f871520
KNOX-3097 - Add more redirect.whitelist Test Cases for KNOXSSOUT
lmccay Feb 17, 2025
0da9693
KNOX-3097 - revert
lmccay Feb 17, 2025
f227883
KNOX-3097 - Adding more redirect.whitelist Test Cases for KNOXSSOUT
lmccay Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...ice-knoxsso/src/test/java/org/apache/knox/gateway/service/knoxsso/WebSSOResourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,19 @@ public void testWhitelistMatchingAgainstBaseURL() throws MalformedURLException {
"https://google.com/https://KNOX_GW_DOMAIN"));
}

@Test
public void testMaliciousOriginalUrl() throws Exception {
String whitelist = "^(?!.*([<>\"'`{}|\\\\^]|<script|%3cscript|javascript:|data:|alert\\(|onclick=))(^https?://.*example.com/.*)$";

// make sure it is malicious and therefore does NOT match
assertFalse(RegExUtils.checkWhitelist(whitelist, "https://example.com/path?param=%3e%3cscript%3e"));
// make sure it matches because it is not malicious
assertTrue(RegExUtils.checkWhitelist(whitelist, "https://example.com/path"));
}

@Test(expected = MalformedURLException.class)
public void testMalformedOriginalUrl() throws MalformedURLException {
RegExUtils.checkBaseUrlAgainstWhitelist(".*", "https://localhost:5003gateway/homepage/home/");
RegExUtils.checkBaseUrlAgainstWhitelist(".*", "https://localhost:5003gateway/homepage/home/");
}

private void configureCommonExpectations(Map<String, String> contextExpectations) throws Exception {
Expand Down
Loading