Fix wrongly check if the migrating slot in the source node#269
Merged
PragmaTwice merged 2 commits intoapache:unstablefrom Feb 20, 2025
Merged
Fix wrongly check if the migrating slot in the source node#269PragmaTwice merged 2 commits intoapache:unstablefrom
PragmaTwice merged 2 commits intoapache:unstablefrom
Conversation
Kvrocks will return `migrating_slot(s)` instead of `migrating_slot` after the slot range migration is supported. From the controller, we need to allow both of them to be compatiable with the old behavior.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #269 +/- ##
============================================
+ Coverage 43.38% 47.01% +3.62%
============================================
Files 37 45 +8
Lines 2971 4222 +1251
============================================
+ Hits 1289 1985 +696
- Misses 1544 2029 +485
- Partials 138 208 +70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
torwig
approved these changes
Feb 19, 2025
PragmaTwice
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kvrocks will return
migrating_slot(s)instead ofmigrating_slotafter the slot range migration is supported. From the controller, we
need to allow both of them to be compatible with the old behavior.
This close #267.