Skip to content

Fix wrongly check if the migrating slot in the source node#269

Merged
PragmaTwice merged 2 commits intoapache:unstablefrom
git-hulk:fix/issue-267
Feb 20, 2025
Merged

Fix wrongly check if the migrating slot in the source node#269
PragmaTwice merged 2 commits intoapache:unstablefrom
git-hulk:fix/issue-267

Conversation

@git-hulk
Copy link
Member

Kvrocks will return migrating_slot(s) instead of migrating_slot
after the slot range migration is supported. From the controller, we
need to allow both of them to be compatible with the old behavior.

This close #267.

 Kvrocks will return `migrating_slot(s)` instead of `migrating_slot`
 after the slot range migration is supported. From the controller, we
 need to allow both of them to be compatiable with the old behavior.
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.01%. Comparing base (6c56470) to head (e5d00fd).
⚠️ Report is 104 commits behind head on unstable.

Files with missing lines Patch % Lines
controller/cluster.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #269      +/-   ##
============================================
+ Coverage     43.38%   47.01%   +3.62%     
============================================
  Files            37       45       +8     
  Lines          2971     4222    +1251     
============================================
+ Hits           1289     1985     +696     
- Misses         1544     2029     +485     
- Partials        138      208      +70     
Flag Coverage Δ
unittests 47.01% <25.00%> (+3.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PragmaTwice PragmaTwice merged commit 0032e54 into apache:unstable Feb 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slot migration fails when "--slot-only" option is false.

4 participants