Skip to content

migration: fix log for slot migration success#277

Merged
git-hulk merged 1 commit intoapache:unstablefrom
travisshivers:fix-migrate-log
Mar 19, 2025
Merged

migration: fix log for slot migration success#277
git-hulk merged 1 commit intoapache:unstablefrom
travisshivers:fix-migrate-log

Conversation

@travisshivers
Copy link
Contributor

Previously, the code was trying to log the migrated slot after calling ClearMigrateState, which set the migrated slot to -1. Instead, capture the slot number so we can properly log it later.

Previously, the code was trying to log the migrated slot after
calling ClearMigrateState, which set the migrated slot to -1.
Instead, capture the slot number so we can properly log it later.
@travisshivers travisshivers changed the title migration: fix log for slog migration success migration: fix log for slot migration success Mar 18, 2025
@torwig torwig requested a review from git-hulk March 18, 2025 06:52
@torwig
Copy link
Contributor

torwig commented Mar 18, 2025

@travisshivers Thank you for your vigilance.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.25%. Comparing base (6c56470) to head (4a371f3).
⚠️ Report is 100 commits behind head on unstable.

Files with missing lines Patch % Lines
controller/cluster.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #277      +/-   ##
============================================
+ Coverage     43.38%   46.25%   +2.87%     
============================================
  Files            37       45       +8     
  Lines          2971     4287    +1316     
============================================
+ Hits           1289     1983     +694     
- Misses         1544     2096     +552     
- Partials        138      208      +70     
Flag Coverage Δ
unittests 46.25% <0.00%> (+2.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@git-hulk git-hulk merged commit 8b0eda8 into apache:unstable Mar 19, 2025
4 checks passed
@travisshivers travisshivers deleted the fix-migrate-log branch December 11, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants