feat(webui): redesign the footer element#287
Conversation
adding license
|
@shubham-j-sde That said, quite possible in future we might consider migrating the project from JSX to TSX, so keeping your files in TSX could be beneficial. Its just a suggestion, you can proceed however you'd like. |
|
I see that, but
Honestly, i believe current code lacks even some Next.js module standards, not to mention basic web accessibility standards. and that's what we need to work upon. your thoughts? |
This is very true and i agree with this the sooner we adapt with thr typescript ecosystem the better. However, this is an important decision, and while I'm happy to contribute in any way I can, the final call rests with the maintainers. Looking ahead, whether now or in the future, transitioning to typescript will be essential for a long-term development strategy.
NextJS is amazing and offers a lot of cool stuff with optimizations and all, I believe this can be worked later on. As the current focus is to develop a MVP of the kvrocks-controller with the essential things integrated in it. |
|
@SharonIV0x86 , I really value your time and opinion and our brainstorming discussion to decide whats best for community and users of Kvrocks and Cluster controller. and I'd be happy to change to JSX if needed. but as we are still discussing, i'd propose reasons for why to include TS now.
Yeah I agree with you and i am saying both things are possible, so we do them along with using best practices together. 😃
It's not transitioning if done now, current website got live just a few days back, so it will cost no additional bandwidth. Doing this now would save lot of future bandwidth (which are difficult to get hold of for open source project) for community to work upon developing new features, This would also save any possible downtime for users during future migration. Using modern practices also means less worry for dependency failures in near future.
And Lack of Module standards is Red Flag for Open Source project as it hinders new users to follow code and contribute. |
|
Thank you for your contribution! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #287 +/- ##
============================================
+ Coverage 43.38% 46.34% +2.95%
============================================
Files 37 45 +8
Lines 2971 4296 +1325
============================================
+ Hits 1289 1991 +702
- Misses 1544 2097 +553
- Partials 138 208 +70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
this resolves #286
I have tried to design footer similar to Kvrocks website.
Open to any suggestions on the same.