Fix serverOnlyPrefixConfigKeys is iterator issue#7110
Closed
turboFei wants to merge 1 commit intoapache:masterfrom
Closed
Fix serverOnlyPrefixConfigKeys is iterator issue#7110turboFei wants to merge 1 commit intoapache:masterfrom
serverOnlyPrefixConfigKeys is iterator issue#7110turboFei wants to merge 1 commit intoapache:masterfrom
Conversation
turboFei
changed the title
serverOnlyPrefixConfigKeys is iterator issueserverOnlyPrefixConfigKeys is iterator issue
pan3793
approved these changes
Jun 24, 2025
pan3793
changed the title
serverOnlyPrefixConfigKeys is iterator issueserverOnlyPrefixConfigKeys is iterator issue
Member
|
sounds dangerous, let's not use "follow-up" but a new ticket for PR that has been included in released versions |
turboFei
added a commit
that referenced
this pull request
Jun 24, 2025
### Why are the changes needed? Followup for #7055 Before this PR, the `serverOnlyPrefixConfigKeys` is type of iterator. After one time iteration, it become empty. In this PR, we convert it to `Set` to fix this issue. ### How was this patch tested? UT. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #7110 from turboFei/exclude_prefix. Closes #7110 91a54b6 [Wang, Fei] prefix Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: Wang, Fei <fwang12@ebay.com> (cherry picked from commit aaac07f) Signed-off-by: Wang, Fei <fwang12@ebay.com>
Member
Author
|
thanks, merging to master and 1.10.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Followup for #7055
Before this PR, the
serverOnlyPrefixConfigKeysis type of iterator.After one time iteration, it become empty.
In this PR, we convert it to
Setto fix this issue.How was this patch tested?
UT.
Was this patch authored or co-authored using generative AI tooling?
No.