Skip to content

[KYUUBI #7101][1.10][FOLLOWUP] Fix code broken#7116

Closed
turboFei wants to merge 1 commit intoapache:branch-1.10from
turboFei:fix_conflicts
Closed

[KYUUBI #7101][1.10][FOLLOWUP] Fix code broken#7116
turboFei wants to merge 1 commit intoapache:branch-1.10from
turboFei:fix_conflicts

Conversation

@turboFei
Copy link
Member

@turboFei turboFei commented Jun 26, 2025

Why are the changes needed?

Address comment: #7101 (comment)

How was this patch tested?

GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (65581a2) to head (f25f487).
Report is 3 commits behind head on branch-1.10.

Files with missing lines Patch % Lines
...kyuubi/engine/KubernetesApplicationOperation.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           branch-1.10   #7116   +/-   ##
===========================================
  Coverage         0.00%   0.00%           
===========================================
  Files              692     692           
  Lines            42875   42904   +29     
  Branches          5823    5827    +4     
===========================================
- Misses           42875   42904   +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@turboFei turboFei requested a review from pan3793 June 26, 2025 19:47
@turboFei turboFei added this to the v1.10.3 milestone Jun 26, 2025
@turboFei turboFei self-assigned this Jun 26, 2025
@turboFei
Copy link
Member Author

turboFei commented Jul 2, 2025

cc @pan3793

pan3793 pushed a commit that referenced this pull request Jul 2, 2025
### Why are the changes needed?

Address comment: #7101 (comment)

### How was this patch tested?

GA.
### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #7116 from turboFei/fix_conflicts.

Closes #7101

f25f487 [Wang, Fei] [KYUUBI #7101][1.10][FOLLOWUP] Fix code broken

Authored-by: Wang, Fei <fwang12@ebay.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
@pan3793
Copy link
Member

pan3793 commented Jul 2, 2025

Thanks, merged to branch-1.10

@pan3793 pan3793 closed this Jul 2, 2025
@turboFei turboFei deleted the fix_conflicts branch July 2, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants