[KYUUBI #7109] Ignore the ? in backticks#7125
[KYUUBI #7109] Ignore the ? in backticks#7125ruanwenjun wants to merge 1 commit intoapache:masterfrom
Conversation
7b3b183 to
48c1037
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7125 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 700 700
Lines 43374 43377 +3
Branches 5873 5875 +2
======================================
- Misses 43374 43377 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Kyuubi JDBC Driver is derived from Hive JDBC Driver, was this fixed in Hive project? |
Hive doesn't have a fix for this. 😢 |
|
What about |
Actually, my initial idea was to get it merged into the community first, and then cherry-pick it into our version. Going through the community review process can help reduce the likelihood of bugs. |
|
let me take a look at how |
|
I create jira to Hive: https://issues.apache.org/jira/browse/HIVE-29060?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel Seems they begin to deal with this. |
|
Hive has fixed this yesterday apache/hive@9a68ebc @pan3793 |
48c1037 to
7140980
Compare
### Why are the changes needed? We will split the sql by `?` when we use `KyuubiPreparedStatement`. But there exist corner case when ? exist in backticks. For example, below sql contains `?`, but we shouldn't split it by `?`. ```sql SELECT `(ds|hr)?+.+` FROM sales ``` More details can find at https://hive.apache.org/docs/latest/languagemanual-select_27362043/#regex-column-specification Hive upstream fix - HIVE-29060 ### How was this patch tested? UT. ### Was this patch authored or co-authored using generative AI tooling? NO. Closes #7125 from ruanwenjun/dev_wenjun_fix7109. Closes #7109 7140980 [ruanwenjun] [KYUUBI #7109] Ignore the ? in backticks Lead-authored-by: Wenjun Ruan <wenjun@apache.org> Co-authored-by: ruanwenjun <zyb@wenjuns-MacBook-Pro-2.local> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 4e40f94) Signed-off-by: Cheng Pan <chengpan@apache.org>
|
Thanks, merged to master/1.10 |
Why are the changes needed?
We will split the sql by
?when we useKyuubiPreparedStatement. But there exist corner case when ? exist in backticks.For example, below sql contains
?, but we shouldn't split it by?.More details can find at https://hive.apache.org/docs/latest/languagemanual-select_27362043/#regex-column-specification
Hive upstream fix - HIVE-29060
How was this patch tested?
UT.
Was this patch authored or co-authored using generative AI tooling?
NO.