Skip to content

Transfer engine pool name to lower case#7241

Closed
turboFei wants to merge 2 commits intoapache:masterfrom
turboFei:engine_pool
Closed

Transfer engine pool name to lower case#7241
turboFei wants to merge 2 commits intoapache:masterfrom
turboFei:engine_pool

Conversation

@turboFei
Copy link
Member

@turboFei turboFei commented Nov 8, 2025

Why are the changes needed?

  1. engine pool name is used to build the subdomain.
  2. the subdomain is case-insensitive
  3. however, now, the engine pool name is case sensitive
  4. when we try to delete the engine with subdomain(enginePool-index), it failed to find the zookeeper path

@deprecated("using kyuubi.engine.share.level.subdomain instead", "1.4.0")
val ENGINE_SHARE_LEVEL_SUB_DOMAIN: ConfigEntry[Option[String]] =
buildConf("kyuubi.engine.share.level.sub.domain")
.doc("(deprecated) - Using kyuubi.engine.share.level.subdomain instead")
.version("1.2.0")
.stringConf
.transformToLowerCase

FYI:
Unable to delete the engine zk node with engine pool mode.
image

How was this patch tested?

UT.

Was this patch authored or co-authored using generative AI tooling?

No.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (3b205a3) to head (7cbe255).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #7241   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         696     696           
  Lines       43530   43530           
  Branches     5883    5883           
======================================
  Misses      43530   43530           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@turboFei turboFei closed this in e7f06a3 Nov 8, 2025
turboFei added a commit that referenced this pull request Nov 8, 2025
### Why are the changes needed?

1. engine pool name is used to build the subdomain.
2. the subdomain is case-insensitive
3. however, now, the engine pool name is case sensitive
4. when we try to delete the engine with subdomain(enginePool-index), it failed to find the zookeeper path

https://github.com/apache/kyuubi/blob/bebe10adf369a61b17f1f530126f8808062d2f7e/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala#L2363-L2369

FYI:
Unable to delete the engine zk node with engine pool mode.
<img width="1726" height="120" alt="image" src="https://github.com/user-attachments/assets/363574ed-9c79-435e-a46d-a564b296784b" />

### How was this patch tested?

UT.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #7241 from turboFei/engine_pool.

Closes #7241

7cbe255 [Wang, Fei] UT
c245a40 [Wang, Fei] Transfer engine pool name to lower case

Authored-by: Wang, Fei <fwang12@ebay.com>
Signed-off-by: Wang, Fei <fwang12@ebay.com>
(cherry picked from commit e7f06a3)
Signed-off-by: Wang, Fei <fwang12@ebay.com>
@turboFei turboFei added this to the v1.10.3 milestone Nov 8, 2025
@turboFei
Copy link
Member Author

turboFei commented Nov 8, 2025

thanks, merged to 1.10.3 and 1.11.0

@turboFei turboFei deleted the engine_pool branch November 8, 2025 19:28
@turboFei turboFei self-assigned this Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants