Transfer engine pool name to lower case#7241
Closed
turboFei wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7241 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 696 696
Lines 43530 43530
Branches 5883 5883
======================================
Misses 43530 43530 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pan3793
approved these changes
Nov 8, 2025
turboFei
added a commit
that referenced
this pull request
Nov 8, 2025
### Why are the changes needed? 1. engine pool name is used to build the subdomain. 2. the subdomain is case-insensitive 3. however, now, the engine pool name is case sensitive 4. when we try to delete the engine with subdomain(enginePool-index), it failed to find the zookeeper path https://github.com/apache/kyuubi/blob/bebe10adf369a61b17f1f530126f8808062d2f7e/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala#L2363-L2369 FYI: Unable to delete the engine zk node with engine pool mode. <img width="1726" height="120" alt="image" src="https://github.com/user-attachments/assets/363574ed-9c79-435e-a46d-a564b296784b" /> ### How was this patch tested? UT. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #7241 from turboFei/engine_pool. Closes #7241 7cbe255 [Wang, Fei] UT c245a40 [Wang, Fei] Transfer engine pool name to lower case Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: Wang, Fei <fwang12@ebay.com> (cherry picked from commit e7f06a3) Signed-off-by: Wang, Fei <fwang12@ebay.com>
Member
Author
|
thanks, merged to 1.10.3 and 1.11.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
kyuubi/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
Lines 2363 to 2369 in bebe10a
FYI:

Unable to delete the engine zk node with engine pool mode.
How was this patch tested?
UT.
Was this patch authored or co-authored using generative AI tooling?
No.