Skip to content

Conversation

@turboFei
Copy link
Member

@turboFei turboFei commented Dec 7, 2025

Why are the changes needed?

To fix failure:

:2025-12-07 13:40:40.747 ERROR [KyuubiRestFrontendService-134] org.apache.kyuubi.server.api.v1.InternalRestClient: (Ping to internal Kyuubi instance:{}  failed,kyuubistaging-1.kyuubistaginghl.kyuubi-prod.svc.166.tess.io:10011,java.lang.IllegalArgumentException: requirement failed: The auth user shall be not null)

In this PR, it will use the authUser and client ipAddress for internal ping.

How was this patch tested?

Integration testing.

Was this patch authored or co-authored using generative AI tooling?

No.

@turboFei turboFei changed the title [KYUUBI #6884][FOLLOWUP] FIx internal kyuubi instance ping failure [KYUUBI #6884][FOLLOWUP] Fix internal kyuubi instance ping failure Dec 7, 2025
@turboFei turboFei added this to the v1.11.0 milestone Dec 7, 2025
@turboFei turboFei self-assigned this Dec 7, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (fba1f94) to head (198dc61).

Files with missing lines Patch % Lines
...ache/kyuubi/server/api/v1/InternalRestClient.scala 0.00% 8 Missing ⚠️
...ain/java/org/apache/kyuubi/client/BaseRestApi.java 0.00% 2 Missing ⚠️
.../apache/kyuubi/server/api/v1/BatchesResource.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #7264   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         696     696           
  Lines       43530   43537    +7     
  Branches     5883    5885    +2     
======================================
- Misses      43530   43537    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@turboFei turboFei closed this in 2f702a3 Dec 11, 2025
@turboFei
Copy link
Member Author

thanks, merged to 1.11.0

@turboFei turboFei deleted the ping_able branch December 11, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants