Skip to content

Conversation

@pan3793
Copy link
Member

@pan3793 pan3793 commented Dec 26, 2025

Why are the changes needed?

I hit an issue while preparing 1.11.0 RC0, which indicates I need to use a higher version of JDK for releasing.

[INFO] --- antlr4:4.13.1:antlr4 (default) @ kyuubi-extension-spark-4-0_2.13 ---
[WARNING] Error injecting: org.antlr.mojo.antlr4.Antlr4Mojo
java.lang.UnsupportedClassVersionError: org/antlr/v4/Tool has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0
    at java.lang.ClassLoader.defineClass1 (Native Method)
    at java.lang.ClassLoader.defineClass (ClassLoader.java:756)
    at java.security.SecureClassLoader.defineClass (SecureClassLoader.java:142)

In #7144, we made it always use -release:8 for jdk9+, so we still produce Java 8 compatible bytecode even using JDK 17, for all modules except Spark 4.0/4.1 extension modules.

How was this patch tested?

Will verify this in the next RC of 1.11.0

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added kind:documentation Documentation is a feature! kind:build labels Dec 26, 2025
@pan3793
Copy link
Member Author

pan3793 commented Dec 26, 2025

cc @wForget

also cc @aajisaka, this only affects 1.11.0, for 1.10.3, release still uses Java 8

@pan3793 pan3793 requested a review from wForget December 26, 2025 06:10
Copy link
Member

@wForget wForget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pan3793 , LGTM

@pan3793 pan3793 self-assigned this Dec 26, 2025
@pan3793 pan3793 added this to the v1.11.0 milestone Dec 26, 2025
@pan3793 pan3793 closed this in eecdaaa Dec 26, 2025
pan3793 added a commit that referenced this pull request Dec 26, 2025
### Why are the changes needed?

I hit an issue while preparing 1.11.0 RC0, which indicates I need to use a higher version of JDK for releasing.

```
[INFO] --- antlr4:4.13.1:antlr4 (default)  kyuubi-extension-spark-4-0_2.13 ---
[WARNING] Error injecting: org.antlr.mojo.antlr4.Antlr4Mojo
java.lang.UnsupportedClassVersionError: org/antlr/v4/Tool has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0
    at java.lang.ClassLoader.defineClass1 (Native Method)
    at java.lang.ClassLoader.defineClass (ClassLoader.java:756)
    at java.security.SecureClassLoader.defineClass (SecureClassLoader.java:142)
```

In #7144, we made it always use `-release:8` for `jdk9+`, so we still produce Java 8 compatible bytecode even using JDK 17, for all modules except Spark 4.0/4.1 extension modules.

### How was this patch tested?

Will verify this in the next RC of 1.11.0

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #7289 from pan3793/release-java17.

Closes #7289

17e29be [Cheng Pan] Release requires Java 17 or 21

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit eecdaaa)
Signed-off-by: Cheng Pan <[email protected]>
@pan3793
Copy link
Member Author

pan3793 commented Dec 26, 2025

thanks, merged to master/1.11, will continue the 1.11.0 release

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (45860bd) to head (17e29be).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #7289   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         698     698           
  Lines       43636   43636           
  Branches     5893    5893           
======================================
  Misses      43636   43636           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:build kind:documentation Documentation is a feature!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants