Skip to content

Conversation

@ppkarwasz
Copy link
Contributor

The log4j-codegen module was moved from Log4j Core 2 and generates code for custom loggers.

Since:

  1. We don't recommend the usage of custom logger wrappers.
  2. The functionality of a custom logger wrapper can be easily replaced by the usage of the appropriate Level parameter.

I propose to remove the log4j-codegen module.

The `log4j-codegen` module was moved from Log4j Core 2 and generates code for custom loggers.

Since:

1. We don't recommend the usage of custom logger wrappers.
2. The functionality of a custom logger wrapper can be easily replaced by the usage of the appropriate `Level` parameter.

I propose to remove the `log4j-codegen` module.
Copy link
Member

@vy vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(AFAIU, this has never been released with log4j-transform – please correct me if I'm wrong.)

@ppkarwasz
Copy link
Contributor Author

(AFAIU, this has never been released with log4j-transform – please correct me if I'm wrong.)

No, it has never been released, so the appropriate time to remove it is now.
If in the future we decide to release it, we can reverse this PR.

@ppkarwasz ppkarwasz merged commit b71af98 into main Dec 15, 2024
9 checks passed
@ppkarwasz ppkarwasz deleted the feature/remove-codegen branch December 15, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants