Skip to content

Conversation

@Goooler
Copy link
Member

@Goooler Goooler commented Jan 23, 2025

No description provided.

@Goooler Goooler force-pushed the optimize-test-relocation branch from 5534fd6 to 8259abe Compare January 23, 2025 03:06
@vy
Copy link
Member

vy commented Jan 23, 2025

@Goooler, thanks so much for the contribution! 💯 Would you mind GPG-signing all your commits and force-pushing again, please?

This SO post explains how to sign old commits. I suggest you to globally enable commit.gpgsign configuration (i.e., git config --global commit.gpgsign true) to avoid having such problems in the future. Please note that GPG signing (which is what I am asking for) and signing off are not the same things.

@Goooler Goooler force-pushed the optimize-test-relocation branch from 8259abe to b748fa0 Compare January 23, 2025 07:06
@Goooler
Copy link
Member Author

Goooler commented Jan 23, 2025

@vy Done! Thanks for your reminder.

@vy vy changed the title Optimize testRelocation with parameterized test Use paremeterized tests in Log4j2PluginCacheFileTransformerTest Jan 23, 2025
@vy vy merged commit 7d9b493 into apache:main Jan 23, 2025
9 checks passed
@vy vy self-assigned this Jan 23, 2025
@Goooler Goooler deleted the optimize-test-relocation branch January 23, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants