Skip to content

Support for unplanned logger calls #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Support for unplanned logger calls #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa428a7
Support for unplanned logger calls
SgtOmer Sep 6, 2025
84a1e32
added tests for unplanned logging and removed manual line counting
SgtOmer Sep 6, 2025
e924f9b
remove manual lines completely
SgtOmer Sep 6, 2025
5b56d8b
spotless
SgtOmer Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions ...-weaver/src/main/java/org/apache/logging/log4j/weaver/log4j2/LoggerConversionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,25 +132,15 @@ public void handleMethodInstruction(LocationMethodVisitor mv, String name, Strin
case "throwing":
handleCatchingThrowing(mv, descriptor, "throwing".equals(name));
break;
case "isDebugEnabled":
case "isEnabled":
case "isErrorEnabled":
case "isFatalEnabled":
case "isInfoEnabled":
case "isTraceEnabled":
case "isWarnEnabled":
case "logMessage":
// These are NOPs
mv.invokeInterface(LOGGER_TYPE, new Method(name, descriptor));
break;
case "traceEntry":
handleTraceEntry(mv, descriptor);
break;
case "traceExit":
handleTraceExit(mv, descriptor);
break;
default:
throw new ConversionException("Unsupported method 'org.apache.logging.log4j.Logger#" + name + "'.");
// The default is to not change the original call
mv.invokeInterface(LOGGER_TYPE, new Method(name, descriptor));
}
}

Expand Down
Loading