Skip to content

Conversation

kurtostfeld
Copy link

@kurtostfeld kurtostfeld commented May 31, 2025

Upgrade Jackson from 2.x to 3.0.0-rc5

@kurtostfeld kurtostfeld force-pushed the jackson3-upgrade branch 2 times, most recently from c10d154 to f4a69b1 Compare June 7, 2025 04:13
@ppkarwasz ppkarwasz self-assigned this Jun 19, 2025
@ppkarwasz
Copy link
Contributor

Hi @kurtostfeld,

Thank you for your patience. Now that we've released version 2.25.0, I’ll have time to return to the 3.x branch and plan to review your PR soon.

Appreciate your contribution!

@kurtostfeld kurtostfeld changed the title Upgrade Jackson from 2.x to 3.0.0-rc4 Upgrade Jackson from 2.x to 3.0.0-rc5 Jun 20, 2025
@kurtostfeld
Copy link
Author

@ppkarwasz thank you! I see the windows build is failing. I only have MacBooks, but I'll try to figure out what could be causing that.

@ppkarwasz
Copy link
Contributor

Hi @kurtostfeld,

No need to worry about the Windows build — we have a number of known flaky tests that tend to fail more frequently on Windows. This is largely due to how GitHub runners are provisioned: unlike Linux runners, which use containers, Windows runners are full virtual machines. They tend to be slower and more prone to timing-related issues, which makes race conditions more likely to surface.

We track these flaky tests in Develocity though we rarely find the time to fix them properly. If you're interested in digging into one of these and exploring what kind of synchronization might be missing, contributions are always welcome!

Thanks again for your work on this PR.

@kurtostfeld
Copy link
Author

@ppkarwasz awesome. I suspected it was a flaky test. thank you. If there are issues with the Jackson 3.0 upgrade, I'd like to help investigate and resolve them. I use log4j on a lot of work projects, and we'd like to see Jackson 3.0 in the log4j 3.0 release. Thank you :)

@kurtostfeld kurtostfeld changed the title Upgrade Jackson from 2.x to 3.0.0-rc5 Upgrade Jackson from 2.x to 3.0.0-rc8 Aug 28, 2025
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kurtostfeld,

This looks great, thanks! 💯

Can you add a changelog entry to src/changelog/.3.x.x? Our custom changelog format is documented on our website, but it should be easy grasp from the entries already present.

Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kurtostfeld,

This looks good to me and since Jackson released 3.0.0 it is the best time to merge it. Thank you again for your work! 💯

@ppkarwasz ppkarwasz enabled auto-merge (squash) October 7, 2025 08:28
@ppkarwasz ppkarwasz merged commit 4e44a28 into apache:main Oct 7, 2025
6 of 7 checks passed
@github-project-automation github-project-automation bot moved this from To triage to Done in Log4j bug tracker Oct 7, 2025
@kurtostfeld
Copy link
Author

@ppkarwasz Wow, merged! Amazing! Thank you!

@ppkarwasz ppkarwasz mentioned this pull request Oct 11, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants