-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Upgrade Jackson from 2.x to 3.0.0-rc8 #3701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c10d154
to
f4a69b1
Compare
f4a69b1
to
796bda7
Compare
Hi @kurtostfeld, Thank you for your patience. Now that we've released version 2.25.0, I’ll have time to return to the 3.x branch and plan to review your PR soon. Appreciate your contribution! |
@ppkarwasz thank you! I see the windows build is failing. I only have MacBooks, but I'll try to figure out what could be causing that. |
796bda7
to
86bf5ae
Compare
Hi @kurtostfeld, No need to worry about the Windows build — we have a number of known flaky tests that tend to fail more frequently on Windows. This is largely due to how GitHub runners are provisioned: unlike Linux runners, which use containers, Windows runners are full virtual machines. They tend to be slower and more prone to timing-related issues, which makes race conditions more likely to surface. We track these flaky tests in Develocity though we rarely find the time to fix them properly. If you're interested in digging into one of these and exploring what kind of synchronization might be missing, contributions are always welcome! Thanks again for your work on this PR. |
86bf5ae
to
aa54a5a
Compare
@ppkarwasz awesome. I suspected it was a flaky test. thank you. If there are issues with the Jackson 3.0 upgrade, I'd like to help investigate and resolve them. I use log4j on a lot of work projects, and we'd like to see Jackson 3.0 in the log4j 3.0 release. Thank you :) |
aa54a5a
to
738fd66
Compare
738fd66
to
7e8a42b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kurtostfeld,
This looks great, thanks! 💯
Can you add a changelog entry to src/changelog/.3.x.x
? Our custom changelog format is documented on our website, but it should be easy grasp from the entries already present.
6a8c413
to
358b46b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kurtostfeld,
This looks good to me and since Jackson released 3.0.0
it is the best time to merge it. Thank you again for your work! 💯
@ppkarwasz Wow, merged! Amazing! Thank you! |
Upgrade Jackson from 2.x to 3.0.0-rc5