Fix use of AccessController in LoaderUtil #2138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue apache#2129 where `AccessController::doPrivileged` is needlessly invoked when no `SecurityManager` is installed.
jvz
added
bug
ppkarwasz
requested changes
Dec 29, 2023
log4j-api/src/main/java/org/apache/logging/log4j/util/LoaderUtil.java
Outdated
Show resolved
Hide resolved
|
@jvz, would you also mind adding tests too, please? |
Turns out Android doesn't support Java 8 all that much.
ppkarwasz
approved these changes
Dec 31, 2023
| static { | ||
| if (System.getSecurityManager() != null) { | ||
| boolean getClassLoaderDisabled; | ||
| static final RuntimePermission GET_CLASS_LOADER = new RuntimePermission("getClassLoader"); |
There was a problem hiding this comment.
Unless I am mistaken, this is no longer necessary.
There was a problem hiding this comment.
It's used for checking if we have the ability to use the permission in full-permission mode to see if we should just fall back to the class loader of this class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #2129 where
AccessController::doPrivilegedis needlessly invoked when noSecurityManageris installed.