Skip to content

Optimize the parameter passing and lambda creation. #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Optimize the parameter passing and lambda creation. #2183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...src/main/java/org/apache/logging/log4j/layout/template/json/resolver/MessageResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,17 +99,16 @@ private static EventResolver createInternalResolver(final TemplateResolverConfig
if (stringified && fallbackKey != null) {
throw new IllegalArgumentException("fallbackKey is not allowed when stringified is enable: " + config);
}
return stringified ? createStringResolver(fallbackKey) : createObjectResolver(fallbackKey);
return stringified ? createStringResolver() : createObjectResolver(fallbackKey);
}

@Override
public void resolve(final LogEvent logEvent, final JsonWriter jsonWriter) {
internalResolver.resolve(logEvent, jsonWriter);
}

private static EventResolver createStringResolver(final String fallbackKey) {
return (final LogEvent logEvent, final JsonWriter jsonWriter) ->
resolveString(fallbackKey, logEvent, jsonWriter);
private static EventResolver createStringResolver() {
return (final LogEvent logEvent, final JsonWriter jsonWriter) -> resolveString(null, logEvent, jsonWriter);
}

private static void resolveString(final String fallbackKey, final LogEvent logEvent, final JsonWriter jsonWriter) {
Expand Down