[LOG4J2-3680] Allow deserialization of arrays #2259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vy
approved these changes
Feb 5, 2024
log4j-api/src/main/java/org/apache/logging/log4j/util/internal/SerializationUtil.java
Outdated
Show resolved
Hide resolved
log4j-api/src/main/java/org/apache/logging/log4j/util/internal/SerializationUtil.java
Show resolved
Hide resolved
The `DefaultObjectInputFilter` is too restrictive and it does not allow the deserialization of **arrays** of classes in the `SerializationUtil#REQUIRED_JAVA_CLASSES` and `SerializationUtil#REQUIRED_JAVA_PACKAGES` white lists. Most notably `RuntimeException` can not be deserialized, since it contains an array of `StackTraceElement`s. Both classes are allowed, but deserialization of the array fails.
ppkarwasz
force-pushed
the
fix/3680_serialize_arrays
branch
from
2b50e38 to
249a4f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DefaultObjectInputFilteris too restrictive and it does not allow the deserialization of arrays of whitelisted classes.Most notably
RuntimeExceptioncan not be deserialized, since it contains an array ofStackTraceElements. Both classes are allowed, but deserialization of theStackTraceElement[]array fails.We also replace all manual serializations/deserializations in test classes to calls to
SerialUtil. This guarantees a consistent behavior of all tests under Java 8 and Java 9+.