Skip to content

Improve GraalVM support of SimpleLoggerContext #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2024
Merged

Improve GraalVM support of SimpleLoggerContext #2908

merged 1 commit into from
Aug 31, 2024

Conversation

ppkarwasz
Copy link
Contributor

This PR allows to create GraalVM applications that only use this SimpleLoggerContext.

For this purpose we create a SimpleProvider implementation of Provider, which is not instantiated by reflection.

Part of #2830

@ppkarwasz ppkarwasz mentioned this pull request Aug 30, 2024
Closed
4 tasks
vy
vy approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@vy vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm only concerned about the visibility of the SimpleProvider. It used to be a private member of ProviderUtil. Now it is public, that is, an API liability. Shall we instead move it to an internal package, e.g., o.a.l.l.simple.internal?

@ppkarwasz
Copy link
Contributor Author

LGTM. I'm only concerned about the visibility of the SimpleProvider. It used to be a private member of ProviderUtil. Now it is public, that is, an API liability. Shall we instead move it to an internal package, e.g., o.a.l.l.simple.internal?

Good call, fixed in d20268c.

@ppkarwasz
Improve GraalVM support of SimpleLoggerContext
56313a1 
This PR allows to create GraalVM applications that only use
this `SimpleLoggerContext`.

For this purpose we create a `SimpleProvider` implementation of `Provider`,
which is **not** instantiated by reflection.

Part of #2830
@ppkarwasz ppkarwasz force-pushed the fix/2.x/simple-provider-graalvm branch from d20268c to 56313a1 Compare August 31, 2024 17:47
@ppkarwasz ppkarwasz merged commit 56313a1 into 2.x Aug 31, 2024
6 checks passed
@ppkarwasz ppkarwasz deleted the fix/2.x/simple-provider-graalvm branch August 31, 2024 17:48
@ppkarwasz ppkarwasz added this to the 2.24.0 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vy vy vy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.24.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ppkarwasz @vy