Skip to content

Conversation

ninetteadhikari
Copy link
Contributor

Introduction

We are from Neighbourhoodie, the implementation partner of the STF Bug Resilience Program. This work is part of our agreed Milestone 1. Upgrade from JUnit 4 to JUnit 5. This PR migrates the tests located in log4j-jpl to JUnit5.

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

@vy vy self-assigned this Sep 27, 2024
@vy vy added the tests Pull requests or issues related to tests label Sep 27, 2024
@github-actions
Copy link

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 Build Scan PUBLISHED
Generated by gradle/develocity-actions

@vy vy merged commit 32fb8a4 into apache:2.x Sep 27, 2024
9 checks passed
vy pushed a commit that referenced this pull request Sep 27, 2024
@vy
Copy link
Member

vy commented Sep 27, 2024

@ninetteadhikari, thanks! Merged and ported to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Pull requests or issues related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants