Skip to content

Fix getLogger() incompatibility in log4j-1.2-api #3030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Fix getLogger() incompatibility in log4j-1.2-api #3030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df56da4
fix compile error on OpenJDK
taichi Sep 27, 2024
649a929
Merge branch 'taichi-patch-1' of github.com:taichi/logging-log4j2 int…
ppkarwasz Oct 1, 2024
7acf608
Add changelog entry
vy Oct 1, 2024
6bb1c1e
Merge remote-tracking branch 'apache/2.x' into taichi-patch-1
ppkarwasz Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion log4j-1.2-api/src/main/java/org/apache/log4j/Logger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public class Logger extends Category {
*/
private static final String FQCN = Logger.class.getName();

public static Logger getLogger(final Class<?> clazz) {
public static Logger getLogger(@SuppressWarnings("rawtypes") final Class clazz) {
// Depth 2 gets the call site of this method.
return LogManager.getLogger(clazz.getName(), StackLocatorUtil.getCallerClassLoader(2));
}
Expand Down
8 changes: 8 additions & 0 deletions src/changelog/.2.x.x/3030_fix_log4j1_getLogger.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns="https://logging.apache.org/xml/ns"
xsi:schemaLocation="https://logging.apache.org/xml/ns https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"
type="fixed">
<issue id="3030" link="https://github.com/apache/logging-log4j2/pull/3030"/>
<description format="asciidoc">Fix `getLogger()` source incompatibility in Log4j 1 to Log4j 2 API Bridge (i.e., `log4j-1.2-api`)</description>
</entry>