Skip to content

Conversation

ppkarwasz
Copy link
Contributor

This is the port of #2941 to main

The HttpWatcher didn't propagate the observed last modification time back to the configuration.
As a result, each new configuration was already deprecated when it started and the reconfiguration process looped.

Closes #2937

Rewrite Jetty tests using WireMock

Closes #2813

ppkarwasz and others added 3 commits October 1, 2024 15:59
The `HttpWatcher` didn't propagate the observed
last modification time back to the configuration.
As a result, each new configuration was already
deprecated when it started and the reconfiguration
process looped.

Closes #2937

Rewrite Jetty tests using WireMock

Closes #2813

Co-authored-by: Volkan Yazıcı <[email protected]>
Copy link
Member

@vy vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed through the changes, LGTM.

@ppkarwasz ppkarwasz merged commit 878962e into main Oct 2, 2024
9 checks passed
@ppkarwasz ppkarwasz deleted the fix/main/port-http-watcher branch October 2, 2024 11:43
dlmarion added a commit to dlmarion/accumulo that referenced this pull request Apr 8, 2025
After bumping the log4j2 dependency to version 2.24.3 we
started noticing extra logging output during the build. This
issue has been reported at apache/logging-log4j2#3100
and is due to the change to the AbstractConfiguration class
in apache/logging-log4j2#3043. As
described in log4j2 issue apache#3100 and at
https://logging.apache.org/log4j/2.x/manual/status-logger.html
the status configuration element is now deprecated and we
are advised to use a system property instead.

Closes apache#5453
dlmarion added a commit to apache/accumulo that referenced this pull request Apr 9, 2025
After bumping the log4j2 dependency to version 2.24.3 we
started noticing extra logging output during the build. This
issue has been reported at apache/logging-log4j2#3100
and is due to the change to the AbstractConfiguration class
in apache/logging-log4j2#3043. As
described in log4j2 issue #3100 and at
https://logging.apache.org/log4j/2.x/manual/status-logger.html
the status configuration element is now deprecated and we
are advised to use a system property instead.

Closes #5453
@ctubbsii
Copy link
Member

These changes made the status logger much more noisy at the INFO level. The extra lifecycle messages should be at the DEBUG level instead. See #3100 (comment)

ddanielr pushed a commit to keith-turner/accumulo that referenced this pull request Apr 24, 2025
After bumping the log4j2 dependency to version 2.24.3 we
started noticing extra logging output during the build. This
issue has been reported at apache/logging-log4j2#3100
and is due to the change to the AbstractConfiguration class
in apache/logging-log4j2#3043. As
described in log4j2 issue apache#3100 and at
https://logging.apache.org/log4j/2.x/manual/status-logger.html
the status configuration element is now deprecated and we
are advised to use a system property instead.

Closes apache#5453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants