-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix reloading of the configuration from HTTP(S) (main
)
#3043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `HttpWatcher` didn't propagate the observed last modification time back to the configuration. As a result, each new configuration was already deprecated when it started and the reconfiguration process looped. Closes #2937 Rewrite Jetty tests using WireMock Closes #2813 Co-authored-by: Volkan Yazıcı <[email protected]>
This was referenced Oct 1, 2024
vy
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed through the changes, LGTM.
This was referenced Oct 30, 2024
dlmarion
added a commit
to dlmarion/accumulo
that referenced
this pull request
Apr 8, 2025
After bumping the log4j2 dependency to version 2.24.3 we started noticing extra logging output during the build. This issue has been reported at apache/logging-log4j2#3100 and is due to the change to the AbstractConfiguration class in apache/logging-log4j2#3043. As described in log4j2 issue apache#3100 and at https://logging.apache.org/log4j/2.x/manual/status-logger.html the status configuration element is now deprecated and we are advised to use a system property instead. Closes apache#5453
dlmarion
added a commit
to apache/accumulo
that referenced
this pull request
Apr 9, 2025
After bumping the log4j2 dependency to version 2.24.3 we started noticing extra logging output during the build. This issue has been reported at apache/logging-log4j2#3100 and is due to the change to the AbstractConfiguration class in apache/logging-log4j2#3043. As described in log4j2 issue #3100 and at https://logging.apache.org/log4j/2.x/manual/status-logger.html the status configuration element is now deprecated and we are advised to use a system property instead. Closes #5453
These changes made the status logger much more noisy at the INFO level. The extra lifecycle messages should be at the DEBUG level instead. See #3100 (comment) |
ddanielr
pushed a commit
to keith-turner/accumulo
that referenced
this pull request
Apr 24, 2025
After bumping the log4j2 dependency to version 2.24.3 we started noticing extra logging output during the build. This issue has been reported at apache/logging-log4j2#3100 and is due to the change to the AbstractConfiguration class in apache/logging-log4j2#3043. As described in log4j2 issue apache#3100 and at https://logging.apache.org/log4j/2.x/manual/status-logger.html the status configuration element is now deprecated and we are advised to use a system property instead. Closes apache#5453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the port of #2941 to
main
The
HttpWatcher
didn't propagate the observed last modification time back to the configuration.As a result, each new configuration was already deprecated when it started and the reconfiguration process looped.
Closes #2937
Rewrite Jetty tests using WireMock
Closes #2813