Skip to content

Conversation

JWT007
Copy link
Contributor

@JWT007 JWT007 commented Nov 4, 2024

This should fix a potential NPE in AsyncWaitStrategyFactoryConfig if the builder 'class' field is not set or set to null/empty string. #3159

  • added notEmpty assert to Builder setFactoryClassName
  • changed notNull to notEmpty assert to AsyncWaitStrategyFactoryConfig constructor.
  • added changelog XML file.
  • added new tests to AsyncWaitStrategyFactoryConfigTest

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

Copy link

github-actions bot commented Nov 4, 2024

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 Build Scan PUBLISHED
Generated by gradle/develocity-actions

@ppkarwasz ppkarwasz self-assigned this Dec 4, 2024
@JWT007
Copy link
Contributor Author

JWT007 commented Feb 12, 2025

Closing this PR - will cleanup and resubmit.

@JWT007 JWT007 closed this Feb 12, 2025
@JWT007 JWT007 deleted the bugfix/LOG4J-3159 branch February 12, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants