Add missing setter in builder classes #3174
Merged
+49
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds setters to `@PluginBuilderAttribute` fields in setter classes that lack the corresponding public setter.
jaykataria1111
approved these changes
Nov 8, 2024
|
I am rebasing changes for #2769, based on this PR. |
hulkoba
pushed a commit
to neighbourhoodie/logging-log4j2
that referenced
this pull request
Nov 18, 2024
This adds setters to `@PluginBuilderAttribute` fields in setter classes that lack the corresponding public setter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds setters to
@PluginBuilderAttributefields in setter classes that lack the corresponding public setter.