Skip to content

Fix shutdownDisable not taking effect(#2614) #3508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 21, 2025
Merged

Fix shutdownDisable not taking effect(#2614) #3508

merged 7 commits into from
Mar 21, 2025

Conversation

Pluto-syd
Copy link
Contributor

Fix shutdownDisable not taking effect(#2614)

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2025 •
edited
Loading

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
Generated by gradle/develocity-actions

@ppkarwasz ppkarwasz mentioned this pull request Mar 3, 2025
Closed
vy
vy requested changes Mar 14, 2025
View reviewed changes
Copy link
Member

@vy vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pluto-syd, thanks so much for the fix! Would you mind adding a changelog entry file too, please?

ppkarwasz
ppkarwasz approved these changes Mar 14, 2025
View reviewed changes
vy
vy reviewed Mar 14, 2025
View reviewed changes
@ppkarwasz
Copy link
Contributor

This PR need to be merged with 2.x for the CI builds to work properly.

@Pluto-syd
Copy link
Contributor Author

This PR need to be merged with 2.x for the CI builds to work properly.

I looked at why CI didn't pass, and made some changes to the way the log4j-spring-boot module reloaded the configuration to pass CI.

@Pluto-syd Pluto-syd requested review from ppkarwasz and vy March 14, 2025 17:39
@vy
Copy link
Member

vy commented Mar 21, 2025

@Pluto-syd, could you please

  1. update your branch: git pull upstream 2.x (assuming upstream points to [email protected]:apache/logging-log4j2.git)
  2. add a src/changelog/.2.x.x/3508_LoggerContext_shutdownDisable.xml file (there are examples in that directory you can get inspired from)
  3. ensure that ./mvnw clean install -DskipTests && ./mvnw verify -pl :log4j-core,:log4j-core-test,:log4j-spring-boot passes on your machine (see the development guide for details)

@Pluto-syd
Copy link
Contributor Author

@vy Thanks for the reminder.

@ppkarwasz ppkarwasz merged commit b23e9a5 into apache:2.x Mar 21, 2025
11 checks passed
@vy vy added bug Incorrect, unexpected, or unintended behavior of existing code configuration Affects the configuration system in a general way labels Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgoers rgoers rgoers left review comments

@vy vy Awaiting requested review from vy

@ppkarwasz ppkarwasz Awaiting requested review from ppkarwasz

Assignees

No one assigned

Labels

bug Incorrect, unexpected, or unintended behavior of existing code configuration Affects the configuration system in a general way

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Pluto-syd @ppkarwasz @vy @rgoers