Skip to content

Exclude certain standard library classes from docgen type exclusion (#3423) #3568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from
Open

Exclude certain standard library classes from docgen type exclusion (#3423) #3568

wants to merge 3 commits into from

Conversation

jbb01
Copy link

@jbb01 jbb01 commented Mar 22, 2025 •
edited by vy
Loading

This will allow the log4j-docgen-maven-plugin to generate xsd schema attributes for plugin fields with a type of Class, InetAddress, URL, Charset or Pattern. This addresses #3423.

@jbb01
Exclude certain standard library classes from docgen type exclusion
1b46ead 
This will allow the log4j-docgen-maven-plugin to generate xsd schema attributes for plugin fields with a type of Class, InetAddress, URL, Charset or Pattern.
@jbb01 jbb01 mentioned this pull request Mar 22, 2025
Open
@vy vy self-assigned this Apr 13, 2025
@vy vy added bug Incorrect, unexpected, or unintended behavior of existing code api Affects the public API documentation Pull requests or issues that affect documentation labels Apr 13, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 13, 2025 •
edited
Loading

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 ❌ Build Scan PUBLISHED
Generated by gradle/develocity-actions

@jbb01
Copy link
Author

jbb01 commented Apr 30, 2025

I am somewhat confused as to why the build fails. If I'm reading the logs correctly the spotbugs plugin is complaining about some Java code, but this PR does not change any Java code. Is this an issue with the PR or with the build pipeline?

@ppkarwasz
Copy link
Contributor

I am somewhat confused as to why the build fails. If I'm reading the logs correctly the spotbugs plugin is complaining about some Java code, but this PR does not change any Java code. Is this an issue with the PR or with the build pipeline?

Please merge the changes from 2.x.
The failure is due to an upgrade of Spotbugs, which has more rules now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vy vy vy approved these changes

Assignees

@vy vy

Labels

api Affects the public API bug Incorrect, unexpected, or unintended behavior of existing code documentation Pull requests or issues that affect documentation

Projects

Log4j bug tracker
Status: To triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbb01 @ppkarwasz @vy