-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Enforce RTC style on logging-log4j2
#3582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following the [PMC discussion in September 2024](https://lists.apache.org/thread/6gbos0rn3k4y3wjb1hcgnnols4ogqckl), this PR changes the branch protection rules for the `logging-log4j2` repository: - It requires all changes to `2.x` and `main` to be submitted as PRs. - It requires all PRs to have at least one positive review to be merged. - It requires all conversations to be marked as resolved, before a PR is merged. The current features offered by GitHub do not allow introducing exceptions on the size of the PR or other criteria, so let's try to review 100% of the PRs. Smaller teams manage to do it, so we should be able too.
I'm ok with this change for now. I will be quite loud about it, however, if it ends up being an issue in the future, but I hope that won't be the case! |
If you make small PRs and add two reviewers (e.g., @vy and me), it shouldn't be a problem. |
It won't end up being related to PR size or even making PRs. I would be annoyed if my PRs sit unreviewed. |
If we manage to learn how to use GitHub Projects (in the "Projects" tab, currently team-private), we can keep track of the order in which PRs are waiting for a review. |
I modified this PR according to the vote on Can you check if the values look good to you? I have posted an initial JSON schema of |
As usual with GitHub configuration, a couple more commits where required: |
+1. Support for this, even when it is already merged. |
This change enables the same branch protection that was implemented in `logging-log4j2`. See apache/logging-log4j2#3582 and apache/logging-log4j2#3662
This change enables the same branch protection that was implemented in `logging-log4j2`. See apache/logging-log4j2#3582 and apache/logging-log4j2#3662
Following the PMC discussion in September 2024, this PR changes the branch protection rules for the
logging-log4j2
repository:2.x
andmain
to be submitted as PRs.The current features offered by GitHub do not allow introducing exceptions on the size of the PR or other criteria, so let's try to review 100% of the PRs. Smaller teams manage to do it, so we should be able too.