Skip to content

[LOG4J2-3805] NamedInstantPatternTest#compatibilityOfLegacyPattern fails in timezones with minute offsets (e.g., GMT+05:30) #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2025
Merged

[LOG4J2-3805] NamedInstantPatternTest#compatibilityOfLegacyPattern fails in timezones with minute offsets (e.g., GMT+05:30) #3888

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
264cd1c
[LOG4J2-3805] Skip compatibilityOfLegacyPattern test for fractional t…
ramanathan1504 Aug 19, 2025
bae762d
Merge branch '2.x' into issue-3885
ramanathan1504 Aug 19, 2025
49be1a6
LOG4J2-3885: Add test for ISO8601_OFFSET_DATE_TIME_HH with system def…
ramanathan1504 Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion ...ore-test/src/test/java/org/apache/logging/log4j/core/pattern/NamedInstantPatternTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import java.time.Instant;
import org.apache.logging.log4j.core.time.MutableInstant;
import org.apache.logging.log4j.core.util.internal.instant.InstantPatternFormatter;
import org.junit.jupiter.api.Assumptions;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.EnumSource;

Expand All @@ -40,6 +41,19 @@ void compatibilityOfLegacyPattern(NamedInstantPattern namedPattern) {
Instant javaTimeInstant = Instant.now();
MutableInstant instant = new MutableInstant();
instant.initFromEpochSecond(javaTimeInstant.getEpochSecond(), javaTimeInstant.getNano());
assertThat(legacyFormatter.format(instant)).isEqualTo(formatter.format(instant));
String legacy = legacyFormatter.format(instant);
String modern = formatter.format(instant);
if (namedPattern == NamedInstantPattern.ISO8601_OFFSET_DATE_TIME_HH) {
java.time.ZoneOffset offset =
java.time.ZoneId.systemDefault().getRules().getOffset(java.time.Instant.now());
Assumptions.assumeTrue(
offset.getTotalSeconds() % 3600 == 0,
() -> String.format(
"Skipping test: ISO8601_OFFSET_DATE_TIME_HH requires a whole-hour offset, but system offset is %s",
offset));
assertThat(legacy).isEqualTo(modern);
} else {
assertThat(legacy).isEqualTo(modern);
}
}
}
Loading