Remove jvmrunargs lookup (#3874)
#3892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # log4j-core-test/src/test/java/org/apache/logging/log4j/core/lookup/MainInputArgumentsJmxLookupTest.java # log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/JmxRuntimeInputArgumentsLookup.java # log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/package-info.java # src/changelog/.3.x.x/3874_remove_jvmrunargs_lookup.xml
|
Thanks for reviewing and merging! I appreciate your guidance and support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #3874 (Remove
jvmrunargslookup) intomainto resolve LOG4J2-3887Important
Base your changes on
mainbranch for this PR, since it targets the 3.x line.Context
jvmrunargslookup is always empty #2726 removed the brokenjvmrunargslookup in 2.xjvmrunargslookup #3876 updated documentationjvmrunargslookup #3874 removed the lookup in 2.xjvmrunargslookup inmain#3887 ensures the removal is applied to mainChecklist
✅ Required checks
License: I confirm that my changes are submitted under the Apache License, Version 2.0.
Commit signatures: All commits are signed and verifiable. (See GitHub Docs on Commit Signature Verification).
Code formatting: The code is formatted according to the project’s style guide.
How to check and fix formatting
./mvnw spotless:check./mvnw spotless:applySee the build instructions for details.
Build & Test: Verified that the project builds and all unit tests pass.
How to build the project
Run:
./mvnw verifySee the build instructions for details.
🧪 Tests
jvmrunargsis already covered by existing tests.📝 Changelog
src/changelog/.3.x.x/3874_remove_jvmrunargs_lookup.xmlreflecting removal ofjvmrunargslookup.