Fixing RollingAppenderDeleteAccumulatedCount1Test #3957
+26
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vy
requested changes
Oct 17, 2025
| System.out.println(file + " (" + file.length() + "B) " | ||
| + FixedDateFormat.create(FixedFormat.ABSOLUTE).format(file.lastModified())); | ||
| } | ||
| // Wait until the directory contents stabilize (no size change across two polls) |
There was a problem hiding this comment.
- You don't need
Thread.sleep(), you can remove it. (Awaitility already polls.) - Don't wait until contents stabilize, instead, wait until what you want to verify succeeds. That is, place the entire check logic there.
- Sign all your commits
vy
added
tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stabilize
RollingAppenderDeleteAccumulatedCount1Test.Fixes #3003.