Handle logs with positive CountDirection, extension preservation and placed in dir#232
Merged
FreeAndNil merged 4 commits intoapache:masterfrom Apr 28, 2025
Conversation
…n RollingFileAppender for positive CountDirection, extension preservation and logs in dir
gdziadkiewicz
force-pushed
the
Fix_#231_Positive_CountDirection_roll
branch
from
965ba37 to
45f4086
Compare
This was referenced Mar 28, 2025
gdziadkiewicz
added a commit
to gdziadkiewicz/logging-log4net
that referenced
this pull request
Jun 22, 2025
gdziadkiewicz
added a commit
to gdziadkiewicz/logging-log4net
that referenced
this pull request
Jun 25, 2025
gdziadkiewicz
added a commit
to gdziadkiewicz/logging-log4net
that referenced
this pull request
Jun 28, 2025
FreeAndNil
pushed a commit
that referenced
this pull request
Jul 2, 2025
* Add draft of tests for file rolling regression * Add additional tests, fix the restart bug and roll back test-focused changes from #232 * Add test for no name in File case * Adjust paths to work on Linux and macOS * Clean up and unify * Improve style * Add comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #231
Problem
PreserveLogFileNameExtensionwas cutting off the directory part that could be present on config'sFileoption. It resulted in unbound rolling of files in the scenario described in the linked issue.Solution
Fix the issue by making the
PreserveLogFileNameExtensioncode branch handle the directory correctly.Testing
It can be tested with the configuration provided in linked issue.