Skip to content

SOLR-15141: Deprecate V2RequestSupport #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch_8x
Choose a base branch
from
Open

SOLR-15141: Deprecate V2RequestSupport #2312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,22 @@ public enum METHOD {

/**If set to true, every request that implements {@link V2RequestSupport} will be converted
* to a V2 API call
*
* @deprecated
*/
@Deprecated
@SuppressWarnings({"rawtypes"})
public SolrRequest setUseV2(boolean flag){
this.usev2 = flag;
return this;
}

/**If set to true use javabin instead of json (default)
/**
* If set to true use javabin instead of json (default)
*
* @deprecated
*/
@Deprecated
@SuppressWarnings({"rawtypes"})
public SolrRequest setUseBinaryV2(boolean flag){
this.useBinaryV2 = flag;
Expand Down
7 changes: 6 additions & 1 deletion solr/solrj/src/java/org/apache/solr/client/solrj/V2RequestSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,17 @@
/**A a request object is able to convert itself to V2 Request
* it should implement this interface
*
* @deprecated
*/
@Deprecated
public interface V2RequestSupport {
/**If usev2 flag is set to true, return V2Request, if not,
/**
* If usev2 flag is set to true, return V2Request, if not,
* return V1 request object
*
* @deprecated
*/
@Deprecated
@SuppressWarnings({"rawtypes"})
SolrRequest getV2Request();
}
2 changes: 1 addition & 1 deletion solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public CollectionAdminRequest(String path, CollectionAction action) {
super(METHOD.GET, path);
this.action = checkNotNull(CoreAdminParams.ACTION, action);
}

@Override
@SuppressWarnings({"rawtypes"})
public SolrRequest getV2Request() {
Expand Down