SOLR-15045: Execute local leader commit in parallel with distributed commits in DistributedZkUpdateProcessor #2449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commits in DistributedZkUpdateProcessor
NOTE: this test jumps through hoops to support "failure" expressed as success, for compatibility with the way distrib shard commit errors are (not) currently propagated back to the client. This behavior is likely a bug in its own right that should be addressed separately, probably before this fix is committed
|
fwiw, I think the gradle precommit is failing on a nocommit comment marking a question about why TOLEADER distrib commit errors aren't propagated back to the client ... not really an issue with this PR per se. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: SOLR-15045