Skip to content

Make SolrInputField name optional #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make SolrInputField name optional #2455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../src/test/org/apache/solr/update/processor/AddSchemaFieldsUpdateProcessorFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public void testEmptyValue() {
SolrInputDocument finalDoc = doc;
expectThrows(AssertionError.class, () -> processAdd("add-fields-no-run-processor", finalDoc));

expectThrows(AssertionError.class, () -> processAdd("add-fields-no-run-processor", new SolrInputDocument(null , null)));
expectThrows(NullPointerException.class, () -> processAdd("add-fields-no-run-processor", new SolrInputDocument(null , null)));
}

public void testSingleField() throws Exception {
Expand Down
5 changes: 3 additions & 2 deletions solr/solrj/src/java/org/apache/solr/common/SolrInputField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import java.util.ArrayList;
import java.util.Collection;
import java.util.Iterator;
import java.util.Objects;

/**
*
Expand All @@ -32,7 +33,7 @@ public class SolrInputField implements Iterable<Object>, Serializable

public SolrInputField( String n )
{
this.name = n;
this.name = Objects.requireNonNull(n);
}

//---------------------------------------------------------------
Expand Down Expand Up @@ -161,7 +162,7 @@ public String getName() {
}

public void setName(String name) {
this.name = name;
this.name = Objects.requireNonNull(name);
}

@Override
Expand Down