Skip to content

[Backport] Provide better impacts for fields indexed with IndexOptions.DOCS #14558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

[Backport] Provide better impacts for fields indexed with IndexOptions.DOCS #14558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4dfba0
Provide better impacts for fields indexed with IndexOptions.DOCS (#14…
gf2121 Apr 25, 2025
5057247
Merge branch 'branch_10_2' into backport_14511_to_branch_10_2
gf2121 Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lucene/CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ Bug Fixes
* GITHUB#14523, GITHUB#14530: Correct TermOrdValComparator competitive iterator so that it forces sparse
field iteration to be at least scoring window baseline when doing intoBitSet. (Ben Trent, Adrien Grand)

* GITHUB#14445: Provide better impacts for fields indexed with IndexOptions.DOCS GITHUB#14511 (Aniketh Jain)

* GITHUB#14543: Fixed lead cost computations for bulk scorers of conjunctive
queries that mix MUST and FILTER clauses, and disjunctive queries that
configure a minimum number of matching SHOULD clauses.
Expand Down
19 changes: 12 additions & 7 deletions lucene/core/src/java/org/apache/lucene/codecs/lucene101/Lucene101PostingsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ public final class Lucene101PostingsReader extends PostingsReaderBase {
private static final List<Impact> DUMMY_IMPACTS =
Collections.singletonList(new Impact(Integer.MAX_VALUE, 1L));

// We stopped storing a placeholder impact with freq=1 for fields with DOCS after 9.12.0
private static final List<Impact> DUMMY_IMPACTS_NO_FREQS =
Collections.singletonList(new Impact(1, 1L));

private final IndexInput docIn;
private final IndexInput posIn;
private final IndexInput payIn;
Expand Down Expand Up @@ -1328,13 +1332,14 @@ public int getDocIdUpTo(int level) {

@Override
public List<Impact> getImpacts(int level) {
if (indexHasFreq) {
if (level == 0 && level0LastDocID != NO_MORE_DOCS) {
return readImpacts(level0SerializedImpacts, level0Impacts);
}
if (level == 1) {
return readImpacts(level1SerializedImpacts, level1Impacts);
}
if (indexHasFreq == false) {
return DUMMY_IMPACTS_NO_FREQS;
}
if (level == 0 && level0LastDocID != NO_MORE_DOCS) {
return readImpacts(level0SerializedImpacts, level0Impacts);
}
if (level == 1) {
return readImpacts(level1SerializedImpacts, level1Impacts);
}
return DUMMY_IMPACTS;
}
Expand Down