Try to fix eclipse configuration after upgrading to gradle 9.1.0. #15252
Conversation
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
| // Collect dependencies from selected configurations | ||
| // and copy them over to a local configuration. | ||
| List<Dependency> subdependencies = new ArrayList<>(); |
There was a problem hiding this comment.
I don't think it's 1:1 the same as before - dependency resolution can end up with different outputs... in theory at least. But it seems to work for me.
There was a problem hiding this comment.
that was my question, too. You create a clone of the config, but how could they differ. I would say it would resolve the config separately (like a new project with all merged configs, correct?).
It may differ, I am opening the project with Groovy, works!
There was a problem hiding this comment.
I think you can theoretically imagine a situation with two configurations having a transitive dependency in different versions - then it would resolve this differently... I think. I wouldn't worry about it though, it's a hack already.
|
It looks like this works. It creates a new one-time configuration by copying all config entries into it. It's then its own config and can resolve it as wanted. Nice! Now I see 2 new errors in Eclipse next to the heisenbug with LeafReaderContext: |
|
This is a bug in the ecj version that ships with my Eclipse release. The field is definitively initialized in the |
|
There's already a bug open at ECJ and fixed already: eclipse-jdt/eclipse.jdt.core#4416 |
|
We don't see the bug in the Gradle build, because we have ECJ I20250926-1800, which has the fix already. |
|
|
||
| // Add gradle plugin portal to the source repository list and | ||
| // apply any ecj source repository hackery the same way as everywhere. | ||
| project.getRepositories().gradlePluginPortal(); |
There was a problem hiding this comment.
There are plugin dependencies (in the build-infra) that wouldn't be resolved from maven central alone and this configuration for Eclipse is set up in the root project (which only has mavenCentral as the source repository).
|
I found another bug with ECJ: eclipse-jdt/eclipse.jdt.core#4449 We can't trust Java 25 compilation with ECJ at the current stage. So all errors or non-errors should be carefully inspected. |
2 participants
Fixes #15250, hopefully.