Fix silly inefficiencies in HnswGraph.NodesIterator implementation #15425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msokolov
commented
Nov 13, 2025
|
|
||
| @Override | ||
| public void mergeOneField(FieldInfo fieldInfo, MergeState mergeState) throws IOException { | ||
| // nocommit |
Contributor
Author
There was a problem hiding this comment.
oops! this snuck in from another branch
msokolov
added a commit
to msokolov/lucene
that referenced
this pull request
Nov 13, 2025
msokolov
added a commit
that referenced
this pull request
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15424
adds
DenseNodesIteratorandHnswGraph.getSortedNodes()now returns aNodesIteratorNo longer copies and sorts all the (already sorted!) nodes on level 0