Skip to content

Allow AlreadyClosedException to be a possible outcome of injecting fake exceptions in TestIndexFileDeleter #15545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dweiss merged 2 commits into from
Jan 3, 2026
Merged

Allow AlreadyClosedException to be a possible outcome of injecting fake exceptions in TestIndexFileDeleter #15545

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f69bac4
Allow AlreadyClosedException to be a possible outcome of injecting fa…
dweiss Jan 2, 2026
534388d
Fix duplicate branches.
dweiss Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions lucene/core/src/test/org/apache/lucene/index/TestIndexFileDeleter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import org.apache.lucene.document.Document;
import org.apache.lucene.document.Field;
import org.apache.lucene.index.IndexWriterConfig.OpenMode;
import org.apache.lucene.store.AlreadyClosedException;
import org.apache.lucene.store.Directory;
import org.apache.lucene.store.IOContext;
import org.apache.lucene.store.IndexInput;
Expand All @@ -41,11 +42,6 @@
import org.apache.lucene.tests.util.TestUtil;
import org.apache.lucene.util.InfoStream;

/*
Verify we can read the pre-2.1 file format, do searches
against it, and add documents to it.
*/

public class TestIndexFileDeleter extends LuceneTestCase {

public void testDeleteLeftoverFiles() throws IOException {
Expand Down Expand Up @@ -440,7 +436,6 @@ public void eval(MockDirectoryWrapper dir) throws IOException {
});

IndexWriterConfig iwc = newIndexWriterConfig(new MockAnalyzer(random()));
// iwc.setMergeScheduler(new SerialMergeScheduler());
MergeScheduler ms = iwc.getMergeScheduler();
if (ms instanceof ConcurrentMergeScheduler) {
final ConcurrentMergeScheduler suppressFakeFail =
Expand Down Expand Up @@ -486,8 +481,12 @@ protected void handleMergeException(Throwable exc) {
}
} catch (Throwable t) {
if (t.toString().contains("fake fail")
|| (t.getCause() != null && t.getCause().toString().contains("fake fail"))) {
// ok
|| (t.getCause() != null && t.getCause().toString().contains("fake fail"))
|| t instanceof AlreadyClosedException) {
// All these conditions are fine.
// AlreadyClosedException can happen if the injected exception (RuntimeException("fake
// fail")) happened inside the concurrent merges and this closed the index writer's
// reader pool.
} else {
throw t;
}
Expand Down