Use Google's maven central mirror on github runners #15550
Conversation
dweiss
added
the
skip-changelog
|
From https://docs.github.com/en/actions/reference/workflows-and-actions/variables I see the |
| project.getRepositories().mavenCentral(); | ||
| // use google's maven central mirror first on github runners. | ||
| // https://github.com/apache/lucene/issues/15541 | ||
| if (project.getProviders().environmentVariable("GITHUB_ACTIONS").isPresent()) { |
There was a problem hiding this comment.
NIT: can we update the logic similar to apply from: file("declare-repositories.gradle") ?
There was a problem hiding this comment.
This is the way it should be done but we can't do the same in declare-repositories.gradle because it's used from contexts where there are no access to providers. So we use what we have access to in declare-repositories.gradle but do it "properly" here.
|
It says: "The name of the action currently running, or the id of a step." Should be sufficient to detect github workflows (not any CI - just github). |
|
Overall LGTM. We can observe the nightly runs with this change. |
2 participants
Those intermittent resolution errors on github runners are hard to work around. Let's see if we can use
google's mirrors instead (on github only) since we're running jenkins jobs separately (using maven central).