-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add Temporal Merge Policy for time-series data #15620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,662
−15
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bd45e5d
First commit
churromorales d7aeda8
Fixing unused parameter failure
churromorales 10e58c9
Add to changes.txt, remove all logs less than warn
churromorales e16d22b
fix java.lang.System#currentTimeMillis() [Don't depend on wall clock …
churromorales 3560f73
Update lucene/core/src/java/org/apache/lucene/index/TemporalMergePoli…
churromorales 07d4761
Update lucene/core/src/java/org/apache/lucene/index/TemporalMergePoli…
churromorales b4bc4b7
Changes per PR review
churromorales 13deb08
Fix the build
churromorales 511a161
Formatting the java code
churromorales 1e9cacf
More changes per PR review
churromorales 7f2f044
Move changelog entry to 10.5
msfroh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be part of next minor version release? We need not wait for 11? I will wait for anyone more versed with this to chime in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i don't know what is the protocol with lucene for these types of changes, I don't believe they need to be in a major version bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 10.5 is perfectly fine. As long as we mark it as "experimental" and it doesn't change any default behaviors. Folks can "opt-in" knowing its experimental and might evolve in the next minor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@churromorales -- I'm going to go ahead and move this to the 10.5 block. Then I can backport it to 10.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course, whatever you feel is best.