Fix tessellator failure by preferring the shared vertex that is the leftmost vertex of the hole#15657
Merged
iverase merged 4 commits intoapache:mainfrom Feb 2, 2026
Merged
Conversation
…eftmost vertex of the hole
Contributor
craigtaverner
left a comment
craigtaverner
left a comment
There was a problem hiding this comment.
LGTM. One spelling mistake in a comment. I also see this is slightly simpler than the original cursor suggestion, which is nice!
Co-authored-by: Craig Taverner <craig@amanzi.com>
iverase
added a commit
that referenced
this pull request
Feb 2, 2026
…eftmost vertex of the hole (#15657)
finnroblin
pushed a commit
to finnroblin/lucene
that referenced
this pull request
Feb 2, 2026
…eftmost vertex of the hole (apache#15657)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't find a solution here so I asked for help to an IA agent and that was its suggestion. It passes all tests. I clean up a bit the suggested solution and it actually makes sense so we avoid having those shared vertex on the inside of the polygon so I will suggest this fix.
fixes #15554